RFR: 8261137: Optimization of Box nodes in uncommon_trap [v2]

Wang Huang whuang at openjdk.java.net
Tue Feb 9 02:36:42 UTC 2021


On Tue, 9 Feb 2021 00:52:31 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> src/hotspot/share/opto/callGenerator.cpp line 582:
>> 
>>> 580:         Node* uncommon_trap_node = delay_boxes.pop();
>>> 581:         int in_edge = uncommon_trap_node->find_edge(res);
>>> 582:         assert(in_edge > 0, "sanity");
>> 
>> If there are several references you need to replace all of them.
>
> +1
> scalar replacement uses range substitution
> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/macro.cpp#L892

Thank you for your review. It's my fault. I will revise this in next commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list