RFR: 8261137: Optimization of Box nodes in uncommon_trap [v2]

[Wang Huang]

On Tue, 9 Feb 2021 00:35:08 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor codes
>
> src/hotspot/share/opto/callGenerator.cpp line 558:
> 
>> 556: 
>> 557: static void delay_box_in_uncommon_trap(CallNode* call, Node* resproj) {
>> 558:   if (resproj != NULL && call->is_CallStaticJava() &&
> 
> IMHO, we should use nullptr here because hotspot now is using c++14.

Thank you for your review. I will change that.

> src/hotspot/share/opto/callGenerator.cpp line 560:
> 
>> 558:   if (resproj != NULL && call->is_CallStaticJava() &&
>> 559:       call->as_CallStaticJava()->is_boxing_method()) {
>> 560:     GraphKit kit(call->jvms());
> 
> you can postpone to construct this object in if(no_use).

Sure. I will change that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401