RFR: 8261137: Optimization of Box nodes in uncommon_trap [v2]

Wang Huang whuang at openjdk.java.net
Sat Feb 27 07:00:46 UTC 2021


On Tue, 9 Feb 2021 00:56:42 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor codes
>
> src/hotspot/share/opto/callGenerator.cpp line 586:
> 
>> 584:         ciInstanceKlass* klass = call->as_CallStaticJava()->method()->holder();
>> 585:         int n_fields = klass->nof_nonstatic_fields();
>> 586:         assert(n_fields == 1, "sanity");
> 
> I think you  also need to check the only non-static field of klass must be a scalar.
> "sanity" is too concise. I think we should leave a message to say it's an auto-boxing class.

Yes. I will revise that. Thank you.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list