RFR: 8260198: TypeInstPtr::dump2() emits multiple lines if Verbose is set [v8]
Xin Liu
xliu at openjdk.java.net
Thu Feb 25 08:51:39 UTC 2021
On Thu, 25 Feb 2021 08:46:08 GMT, Xin Liu <xliu at openjdk.org> wrote:
>> test/hotspot/gtest/utilities/test_ostream.cpp line 69:
>>
>>> 67: }
>>> 68:
>>> 69: static void test_stringStream_tr_delete(stringStream* ss) {
>>
>> I think this is a unit test for `StringUtils::replace_no_expand`. It checks that the function can be used to remove substrings. There is no dependency on `stringStream`. Any string can be used.
>> Could you please move the test to `test_stringUtils.cpp`?
>
> yes, let me move it to test_stringUtils.cpp.
I would like to keep stringStream because I think it's good idea to test the similar scenario.
it's also handy to do memory management.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2178
More information about the hotspot-compiler-dev
mailing list