RFR: 8261137: Optimization of Box nodes in uncommon_trap [v2]

Wang Huang whuang at openjdk.java.net
Sat Feb 27 07:00:46 UTC 2021


On Mon, 8 Feb 2021 18:27:33 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Wang Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refactor codes
>
> src/hotspot/share/opto/callGenerator.cpp line 591:
> 
>> 589:         Node* sobj = new SafePointScalarObjectNode(gvn.type(res)->isa_oopptr(),
>> 590: #ifdef ASSERT
>> 591:                                                   NULL,
> 
> I would suggest to record `call` node here treating it as allocation.

The prototype of the constuctor is  `SafePointScalarObjectNode(const TypeOopPtr* , AllocateNode* , uint, uint)`. However , `call` here is  a `CallStaticJavaNode *` instead of `AllocateNode *`. Do you mean that we just pass the `call` as a record here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2401


More information about the hotspot-compiler-dev mailing list