RFR: 8255216: ciEnv::_break_at_compile isn't in use

[Dan]

On Wed, 16 Dec 2020 21:06:20 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> _break_at_compile is no longer in use and can be safely removed.
>> No new code, and Tier1 tests succeed after code is removed.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8255216
>
> src/hotspot/share/compiler/compileBroker.cpp line 2227:
> 
>> 2225:   }
>> 2226: 
>> 2227:   should_break = directive->BreakAtExecuteOption || task->check_break_at_flags();
> 
> CompileTask::check_break_at_flags is dead code too,  and CIBreakAtOSR, CIBreakAt
> they are all defunct right now.

I wasn't sure whether or not we wanted to roll the removal of all dead code into this issue or just _break_at_compile. The JBS issue specifically mentions _break_at_compile so that's what I removed here - can expand to do other stuff if you think it's a good idea.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1806