RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack

[Aleksey Shipilev]

On Mon, 30 Nov 2020 14:26:23 GMT, Sergey Platonov <github.com+6061213+sergey-platonov at openjdk.org> wrote:

> There is currently a minor bug (just a typo, actually) in the hotspot, leading
> to undefined behavior.

Changes requested by shade (Reviewer).

Submitted: https://bugs.openjdk.java.net/browse/JDK-8257709 -- please rename this PR to "8257709: C1: Double assignment in InstructionPrinter::print_stack" to get it hooked properly. Also, can you please go to https://github.com/sergey-platonov/jdk/actions and check that testing workflow is enabled? If not, can you trigger it manually on your branch?

src/hotspot/share/c1/c1_InstructionPrinter.cpp line 242:

> 240:     fill_to(start_position, ' ');
> 241:     output()->print("locks [");
> 242:     for (int i = 0; i < stack->locks_size(); ++i) {

I would prefer to keep `i++`, as in old code, unless it fixes something I don't quite see.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1519