RFR: 8257709: C1: Double assignment in InstructionPrinter::print_stack

Sergey Platonov github.com+6061213+sergey-platonov at openjdk.java.net
Mon Jan 11 11:23:08 UTC 2021


On Thu, 3 Dec 2020 18:00:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> There is currently a minor bug (just a typo, actually) in the hotspot, leading
>> to undefined behavior.
>
> src/hotspot/share/c1/c1_InstructionPrinter.cpp line 242:
> 
>> 240:     fill_to(start_position, ' ');
>> 241:     output()->print("locks [");
>> 242:     for (int i = 0; i < stack->locks_size(); ++i) {
> 
> I would prefer to keep `i++`, as in old code, unless it fixes something I don't quite see.

Done. Can you, please, create an issue, so I can mention it here?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1519


More information about the hotspot-compiler-dev mailing list