RFR: 8259576: Misplaced curly brace in Matcher::find_shared_post_visit

Aleksey Shipilev shade at openjdk.java.net
Tue Jan 12 10:55:00 UTC 2021


On Tue, 12 Jan 2021 06:50:59 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> SonarCloud demo instance reports the issue here:
>> 
>>     case Op_VectorMaskCmp: {
>>       n->set_req(1, new BinaryNode(n->in(1), n->in(2)));
>>       n->set_req(2, n->in(3));
>>       n->del_req(3);
>>       break;
>>     default: // <----- ERROR
>>       break;
>>     }
>> 
>> "The direct parent of this switch-label is not the body of a switch statement."
>> 
>> This is added by JDK-8223347, and it is an obviously misplaced curly-brace. It is innocuous in current code, but may become problematic as more cases are added to the switch.
>
> Looks good.

Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2031


More information about the hotspot-compiler-dev mailing list