Integrated: 8259576: Misplaced curly brace in Matcher::find_shared_post_visit
Aleksey Shipilev
shade at openjdk.java.net
Tue Jan 12 10:55:01 UTC 2021
On Mon, 11 Jan 2021 18:37:40 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> SonarCloud demo instance reports the issue here:
>
> case Op_VectorMaskCmp: {
> n->set_req(1, new BinaryNode(n->in(1), n->in(2)));
> n->set_req(2, n->in(3));
> n->del_req(3);
> break;
> default: // <----- ERROR
> break;
> }
>
> "The direct parent of this switch-label is not the body of a switch statement."
>
> This is added by JDK-8223347, and it is an obviously misplaced curly-brace. It is innocuous in current code, but may become problematic as more cases are added to the switch.
This pull request has now been integrated.
Changeset: 4697cfa4
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/4697cfa4
Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
8259576: Misplaced curly brace in Matcher::find_shared_post_visit
Reviewed-by: lucy, thartmann
-------------
PR: https://git.openjdk.java.net/jdk/pull/2031
More information about the hotspot-compiler-dev
mailing list