RFR: 8255216: ciEnv::_break_at_compile isn't in use

[Vladimir Kozlov]

On Wed, 20 Jan 2021 17:23:07 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> _break_at_compile is no longer in use and can be safely removed.
>> No new code, and Tier1 tests succeed after code is removed.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8255216
>
>> @danlemmond , I understand Kozlov's comment.
>> 
>> your change [36bc753](https://github.com/openjdk/jdk/commit/36bc753b6ae85392c3f5e34f85464c02b1c037de) covers c2's optimization. There are another 2 places refer to _directive->BreakAtCompileOption. I think you need to change them to env()-> break_at_compile as well.
>> 
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/c1/c1_Compilation.cpp#L449
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/compile.cpp#L506
> 
> Yes, these places should be fixed too.

I would also suggest to change RFE (and this PR) Subject and Description if you do that.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1806