RFR: 8255216: Change _directive->BreakAtCompileOption to env()->break_at_compile()

[Xin Liu]

On Wed, 20 Jan 2021 17:36:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>>> @danlemmond , I understand Kozlov's comment.
>>> 
>>> your change [36bc753](https://github.com/openjdk/jdk/commit/36bc753b6ae85392c3f5e34f85464c02b1c037de) covers c2's optimization. There are another 2 places refer to _directive->BreakAtCompileOption. I think you need to change them to env()-> break_at_compile as well.
>>> 
>>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/c1/c1_Compilation.cpp#L449
>>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/opto/compile.cpp#L506
>> 
>> Yes, these places should be fixed too.
>
> I would also suggest to change RFE (and this PR) Subject and Description if you do that.

Currently ciEnv->break_at_compile() is set if directive->BreakAtExecuteOption || task->check_break_at_flags();
It doesn't consider `C->directive()->BreakAtCompileOption`.  IMHO, [this line](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/compiler/compileBroker.cpp#L2226) should include `|| directive->BreakAtCompileOption`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1806