RFR: 8260029: aarch64: fix typo in verify_oop_array
Aleksey Shipilev
shade at openjdk.java.net
Thu Jan 21 07:59:01 UTC 2021
On Thu, 21 Jan 2021 02:12:47 GMT, Fei Yang <fyang at openjdk.org> wrote:
> In aarch64 verify_oop_array, we scan over array at 'a' for 'count' oops, verifying each one. The step for the loop should be one for each oop instead of 'size'. We may miss verifying some oops in the array if we set the step to 'size'. Also, we should use 'temp' instead of r16 for the compressed oop case. Register r16 defined but not used in this function.
>
> Tier1-3 tested with linux-aarch64 fastdebug build.
This makes sense to me.
However, for testing, you probably need to run with `-XX:+VerifyOops` specifically, because there is only one test in the whole suite that enables it. Something like tier1 would do: `make run-test TEST=tier1 TEST_VM_OPTS=-XX:+VerifyOops`.
-------------
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/2175
More information about the hotspot-compiler-dev
mailing list