RFR: 8259822: [PPC64] Support the prefixed instruction format added in POWER10 [v2]

Corey Ashford github.com+51754783+coreyashford at openjdk.java.net
Wed Jan 27 17:21:42 UTC 2021


On Tue, 26 Jan 2021 18:55:13 GMT, Kazunori Ogata <ogatak at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/assembler_ppc.hpp line 1112:
>> 
>>> 1110:   static int inv_bi_field(int x)  { return inv_opp_u_field(x, 15, 11); }
>>> 1111: 
>>> 1112:   // support to extended opcodes (prefixed instructions) introduced by POWER10
>> 
>> Should this be "introduced by Power ISA 3.1"?  It would be more correct, but probably inconsistent with other, similar comments.
>
> I'll leave it since other comments that refer to a specific ISA implementation use Power X. (I changed POWER10 to Power 10, though.)

ok, sounds good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2095


More information about the hotspot-compiler-dev mailing list