RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]

[David Holmes]

On Thu, 1 Jul 2021 16:18:50 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Rename vm_exit_on_thread_allocation_failure to vm_exit_on_osthread_failure
>>  - Adjust comment
>>  - Comments from PR review:
>>    - remove unnecessary new_thread NULL checks
>>    - adjust some comments
>>    - fix whitespace
>
> src/hotspot/share/compiler/compileBroker.cpp line 939:
> 
>> 937:         && comp->num_compiler_threads() > 0) {
>> 938:       // The new thread is not known to Thread-SMR yet so we can just delete.
>> 939:       delete new_thread;
> 
> Need `new_thread != NULL` check if you do as I suggested in previous comment.

I don't think so, you can apply `delete` to a NULL pointer (whereas previously we could not call `smr_delete` on a NULL pointer.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4629