RFR: 8269466: Factor out the common code for initializing and starting internal VM JavaThreads [v3]
Vladimir Kozlov
kvn at openjdk.java.net
Thu Jul 1 22:54:06 UTC 2021
On Thu, 1 Jul 2021 22:02:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> src/hotspot/share/compiler/compileBroker.cpp line 939:
>>
>>> 937: && comp->num_compiler_threads() > 0) {
>>> 938: // The new thread is not known to Thread-SMR yet so we can just delete.
>>> 939: delete new_thread;
>>
>> Need `new_thread != NULL` check if you do as I suggested in previous comment.
>
> I don't think so, you can apply `delete` to a NULL pointer (whereas previously we could not call `smr_delete` on a NULL pointer.
okay then.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4629
More information about the hotspot-compiler-dev
mailing list