RFR: 8269652: Factor out the common code for creating system j.l.Thread objects

Coleen Phillimore coleenp at openjdk.java.net
Fri Jul 2 18:27:53 UTC 2021


On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

> Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.cpp.)
> 
> It is all very straight-forward.
> 
> Compiler folk I can go one step further and remove CompileBroker::create_thread_oop if desired.
> 
> Testing: tiers 1-3, GHA
> 
> Thanks,
> David

Looks good! Explains the difference between the cases that add to the threadGroup and the ones that don't.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4663


More information about the hotspot-compiler-dev mailing list