RFR: 8269652: Factor out the common code for creating system j.l.Thread objects
David Holmes
david.holmes at oracle.com
Fri Jul 2 22:55:08 UTC 2021
On 3/07/2021 4:27 am, Coleen Phillimore wrote:
> On Fri, 2 Jul 2021 07:03:50 GMT, David Holmes <dholmes at openjdk.org> wrote:
>
>> Please review this simple refactoring to share the common code used to create j.l.Thread instances for the internal VM JavaThreads. (Also fix a missing space from my previous change in thread.cpp.)
>>
>> It is all very straight-forward.
>>
>> Compiler folk I can go one step further and remove CompileBroker::create_thread_oop if desired.
>>
>> Testing: tiers 1-3, GHA
>>
>> Thanks,
>> David
>
> Looks good! Explains the difference between the cases that add to the threadGroup and the ones that don't.
Thanks for the review Coleen.
David
> -------------
>
> Marked as reviewed by coleenp (Reviewer).
>
> PR: https://git.openjdk.java.net/jdk/pull/4663
>
More information about the hotspot-compiler-dev
mailing list