RFR: 8268293: VectorAPI cast operation on mask and shuffle is broken [v3]

[Paul Sandoz]

On Tue, 8 Jun 2021 17:11:42 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Existing implementation of VectoMask.cast and VectorShuffle.cast operation do not generate correct mask compliant with the species passed as the argument.
>> 
>> This patch fixes the implementation and adds the corresponding  cast operation test cases to VectorAPI regression suite.
>
> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8268293: Review comments resolution.

I don't agree in this case expanding logic in the bash scripts. Such complexity is less maintainable. The scripts and templates are already complicated and hard to maintain.

The testing of exception or non-exception cases could be separated out. I was suggesting combing as a convenient way to avoid increasing the complexity in the bash scripts.

i think a better alternative is to explore adding such tests to Vector*ConversionTests, with an additional data provider that provides species arguments for creating the mask and the cast argument, we can have separate data providers for exceptional and non-exceptional cases. Those data providers would embed similar logic that is currently within the bash script.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4392