RFR: 8268293: VectorAPI cast operation on mask and shuffle is broken [v3]
Jatin Bhateja
jbhateja at openjdk.java.net
Tue Jun 8 18:10:14 UTC 2021
On Tue, 8 Jun 2021 17:13:59 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> What concerns me is the additional complexity of the bash script. I would prefer not to increase the complexity and keep it as simple as possible, and place such conditions within Java test code which is more easily maintainable.
>
> In fact i wonder if it makes sense to add such tests to the Vector*ConversionTests?
I understand your point, proposed changes demonstrate flexibility of the infrastructure to support various use cases.
Simple unit testcase will also ease debugging in case of a failure as logic for legality is part or test generation script. Additionally the negative cases are part of smoke tests.
Tests generated using scripts will always be better maintainable.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4392
More information about the hotspot-compiler-dev
mailing list