RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v7]

[Christian Hagedorn]

On Fri, 30 Apr 2021 18:33:53 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Fix XCOMP cases from old framework and turn it into new debug flag -DIgnoreCompilerControls
>>  - Apply review comments: Added new Compiler annotation class for @DontCompile, changed C1 into C1_SIMPLE, refactored code for ExcludeRandom and FlipC1C2, added missing flag description in README, and some other smaller refactoring/renamings
>
> test/lib/jdk/test/lib/hotspot/ir_framework/TestFrameworkPrepareFlags.java line 92:
> 
>> 90:                           + String.join(TestFramework.TEST_VM_FLAGS_DELIMITER, flags)
>> 91:                           + System.lineSeparator() + TestFramework.TEST_VM_FLAGS_END;
>> 92:         TestFrameworkSocket.write(encoding, "flag encoding");
> 
> I don't see a need to use socket here, it will significantly simplify the code, the failure analysis, and reproducing if we just save prepared flags into a file w/ a well-known location (e.g. passed as an argument/property to `TestFrameworkPrepareFlags`), and when used command-line argument file (`@-file`) to pass these flags to the test VM.

Okay, yes it would make it easier. But the socket can be kept for the communication between the test VM and the driver VM?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3508