RFR: 8254129: IR Test Framework to support regex-based matching on the IR in JTreg compiler tests [v7]

[Igor Ignatyev]

On Sun, 2 May 2021 14:39:30 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> test/lib/jdk/test/lib/hotspot/ir_framework/TestFrameworkPrepareFlags.java line 92:
>> 
>>> 90:                           + String.join(TestFramework.TEST_VM_FLAGS_DELIMITER, flags)
>>> 91:                           + System.lineSeparator() + TestFramework.TEST_VM_FLAGS_END;
>>> 92:         TestFrameworkSocket.write(encoding, "flag encoding");
>> 
>> I don't see a need to use socket here, it will significantly simplify the code, the failure analysis, and reproducing if we just save prepared flags into a file w/ a well-known location (e.g. passed as an argument/property to `TestFrameworkPrepareFlags`), and when used command-line argument file (`@-file`) to pass these flags to the test VM.
>
> Okay, yes it would make it easier. But the socket can be kept for the communication between the test VM and the driver VM?

I don't have a strong opinion here. let's start w/ what you have now, we can always change it later if we find that its complexity doesn't bring much value.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3508