RFR: 8267098: AArch64: C1 StubFrames end confusingly

[Alan Hayward]

On Fri, 14 May 2021 13:50:40 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Ok. I was keeping to the existing style of dont_gc_arguments/must_gc_arguments - but I could change those too so they match.
>
> This code is a legacy carried over from x86. It's not necessary to "match". Changing others would be unnecessary churn, and risk breakage.
> 
> There's an urge from some contributors: when I suggest doing something in an easy-to-understand and clean way, people want to change everything else to match. This urge can be resisted, and IMVHO should be in this case. Churn is, in itself, bad.
> 
> And this case, is special, I think, because `does_not_return` uses the "don't do" anti-pattern, where the `true` case was `does_not_return`.

That's fine, I'll leave that part as it. Knowing the motivation for this is useful, as every project is different.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4030