RFR: 8267098: AArch64: C1 StubFrames end confusingly

[Andrew Haley]

On Fri, 14 May 2021 15:21:50 GMT, Alan Hayward <github.com+4146708+a74nh at openjdk.org> wrote:

>> This code is a legacy carried over from x86. It's not necessary to "match". Changing others would be unnecessary churn, and risk breakage.
>> 
>> There's an urge from some contributors: when I suggest doing something in an easy-to-understand and clean way, people want to change everything else to match. This urge can be resisted, and IMVHO should be in this case. Churn is, in itself, bad.
>> 
>> And this case, is special, I think, because `does_not_return` uses the "don't do" anti-pattern, where the `true` case was `does_not_return`.
>
> That's fine, I'll leave that part as it. Knowing the motivation for this is useful, as every project is different.

Sure, thanks. The commonality between this port and x86 means that in many cases we have taken x86 patches and applied them to this port, with a few tweaks. Of course the ports diverge over time, but even after almost ten years it still sometimes works.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4030