RFR: 8275729: Qualified method names in CodeHeap Analytics
Vladimir Kozlov
kvn at openjdk.java.net
Tue Nov 2 23:00:17 UTC 2021
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich <duke at openjdk.java.net> wrote:
> This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be qualified.
> Testing:
> - `make test TEST="gtest"`: Passed
> - `make run-test TEST="tier1"`: Passed
> - `make run-test TEST="tier2"`: Passed
> - `make run-test TEST=serviceability/dcmd/compiler/CodeHeapAnalyticsMethodNames.java`: Passed
Yes, I am currently testing similar fix:
- Klass* klass = method->method_holder();
- assert(klass->is_loader_alive(), "must be alive");
+ Klass* methHolder = method->method_holder();
+ const char* methHolderS = (methHolder == NULL) ? NULL : methHolder->external_name();
+ methHolderS = (methHolderS == NULL) ? "<method holder name unavailable>" : methHolderS;
- ast->print("%s.", klass->external_name());
+ ast->print("%s.", methHolderS);
Note, failed test is `closed` so I have to run testing.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6200
More information about the hotspot-compiler-dev
mailing list