RFR: 8275729: Qualified method names in CodeHeap Analytics
Evgeny Astigeevich
duke at openjdk.java.net
Tue Nov 2 23:08:19 UTC 2021
On Tue, 2 Nov 2021 22:57:23 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
> Yes, I am currently testing similar fix:
>
> ```
> - Klass* klass = method->method_holder();
> - assert(klass->is_loader_alive(), "must be alive");
> + Klass* methHolder = method->method_holder();
> + const char* methHolderS = (methHolder == NULL) ? NULL : methHolder->external_name();
> + methHolderS = (methHolderS == NULL) ? "<method holder name unavailable>" : methHolderS;
>
> - ast->print("%s.", klass->external_name());
> + ast->print("%s.", methHolderS);
> ```
>
> Note, failed test is `closed` so I have to run testing.
Is NULL method holder an acceptable situation? Could it be a sign of a bug?
BTW, `Klass::external_name()` returns `<unknown>` if `Klass::name()` is `NULL`.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6200
More information about the hotspot-compiler-dev
mailing list