RFR: 8276108: Wrong instruction generation in aarch64 backend

Patric Hedlin phedlin at openjdk.java.net
Tue Nov 9 08:41:35 UTC 2021


On Mon, 8 Nov 2021 18:22:52 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 482:
>> 
>>> 480:                "must be, was: %ld, %d", _offset, size);
>>> 481:         unsigned mask = (1 << size) - 1;
>>> 482:         if (_offset < 0 || _offset & mask) {
>> 
>> Prefer(?): (_offset & mask) != 0
>
> This diff is baffling. What changed?

Hardly baffling. The section was changed to conform with style and indentation in the rest of the function.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6212


More information about the hotspot-compiler-dev mailing list