RFR: 8254108: ciReplay: Support incremental inlining [v2]

[Dean Long]

On Wed, 17 Nov 2021 16:17:21 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> This patch adds support to explicitly apply incremental inlining when replay compiling a method if the original compilation of the method was also incrementally inlined. We write a new value when dumping the inline tree to indicate if an inlinee was incrementally inlined (`= 1`) or not (`= 0`). 
>> 
>> To implement this, I updated the `REPLAY_VERSION` to 2 and additionally added a test to verify that old replay file versions are still working. I added some support to modify/remove version numbers of generated replay files in tests. I also refactored the test added by JDK-8275868 to reuse some of the methods.
>> 
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update comments, should_delay and parsing inline_late, fix test if run with -XX:+AlwaysIncrementalInline

src/hotspot/share/opto/bytecodeInfo.cpp line 573:

> 571:                               bool& should_delay) {
> 572:   assert(callee_method != NULL, "caller checks for optimized virtual!");
> 573:   assert(!should_delay || AlwaysIncrementalInline, "should be initialized to false");

I'm not sure how useful this assert is now.  It could be changed to should_delay == AlwaysIncrementalInline, or maybe just removed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/6413