RFR: 8254108: ciReplay: Support incremental inlining [v2]

Christian Hagedorn chagedorn at openjdk.java.net
Thu Nov 18 10:33:33 UTC 2021


On Thu, 18 Nov 2021 08:56:45 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update comments, should_delay and parsing inline_late, fix test if run with -XX:+AlwaysIncrementalInline
>
> src/hotspot/share/opto/bytecodeInfo.cpp line 573:
> 
>> 571:                               bool& should_delay) {
>> 572:   assert(callee_method != NULL, "caller checks for optimized virtual!");
>> 573:   assert(!should_delay || AlwaysIncrementalInline, "should be initialized to false");
> 
> I'm not sure how useful this assert is now.  It could be changed to should_delay == AlwaysIncrementalInline, or maybe just removed?

Agreed, removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6413


More information about the hotspot-compiler-dev mailing list