RFR: 8276108: Wrong instruction generation in aarch64 backend
Andrew Haley
aph at openjdk.java.net
Wed Nov 24 12:25:09 UTC 2021
On Tue, 23 Nov 2021 18:41:00 GMT, Patric Hedlin <phedlin at openjdk.org> wrote:
> Besides the use of addr->scale(), using legitimize_address() is of course cleaner (and adds block comments to the assembly). Generates slightly different code.
I don't understand why the new version, that depends on `addr->scale()` being zero, should be better. Surely having something that works with all values of scale is more robust, or at least no worse, than the suggested change. What's the point of changing this code so that you need `addr->scale()` being zero as a precondition?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6212
More information about the hotspot-compiler-dev
mailing list