RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations [v4]

[John Tortugo]

On Thu, 16 Sep 2021 07:40:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> John Tortugo has updated the pull request incrementally with 146 additional commits since the last revision:
>> 
>>  - Fix merge mistake.
>>  - Merge branch 'jdk-8267265' of https://github.com/JohnTortugo/jdk into jdk-8267265
>>  - Addressing PR feedback: move tests to other directory, add custom tests, add tests for other optimizations, rename some tests.
>>  - 8273197: ProblemList 2 jtools tests due to JDK-8273187
>>    8273198: ProblemList java/lang/instrument/BootClassPath/BootClassPathTest.sh due to JDK-8273188
>>    
>>    Reviewed-by: naoto
>>  - 8262186: Call X509KeyManager.chooseClientAlias once for all key types
>>    
>>    Reviewed-by: xuelei
>>  - 8273186: Remove leftover comment about sparse remembered set in G1 HeapRegionRemSet
>>    
>>    Reviewed-by: ayang
>>  - 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
>>    
>>    Reviewed-by: jiefu, serb
>>  - 8273092: Sort classlist in JDK image
>>    
>>    Reviewed-by: redestad, ihse, dfuchs
>>  - 8273144: Remove unused top level "Sample Collection Set Candidates" logging
>>    
>>    Reviewed-by: iwalulya, ayang
>>  - 8262095: NPE in Flow$FlowAnalyzer.visitApply: Cannot invoke getThrownTypes because tree.meth.type is null
>>    
>>    Co-authored-by: Jan Lahoda <jlahoda at openjdk.org>
>>    Co-authored-by: Vicente Romero <vromero at openjdk.org>
>>    Reviewed-by: jlahoda
>>  - ... and 136 more: https://git.openjdk.java.net/jdk/compare/ac430bf7...463102e2
>
> test/hotspot/jtreg/compiler/c2/irTests/AddINodeIdealizationTests.java line 40:
> 
>> 38: 
>> 39:     @Test
>> 40:     @IR(failOn = {IRNode.LOAD, IRNode.STORE, IRNode.MUL, IRNode.DIV, IRNode.SUB})
> 
> In this test and all the following ones (including the other files), I think you can remove unrelated `failOn` regexes on operations that are not part of the test. For example, in this test you can safely remove `IRNode.MUL, DIV, and SUB`.

Do you think I can remove the "LOAD" and "STORE" as well?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135