RFR: 8267265: Use new IR Test Framework to create tests for C2 IGV transformations [v4]

Christian Hagedorn chagedorn at openjdk.java.net
Mon Oct 4 08:38:10 UTC 2021


On Sat, 2 Oct 2021 00:11:47 GMT, John Tortugo <github.com+2249648+JohnTortugo at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/AddINodeIdealizationTests.java line 40:
>> 
>>> 38: 
>>> 39:     @Test
>>> 40:     @IR(failOn = {IRNode.LOAD, IRNode.STORE, IRNode.MUL, IRNode.DIV, IRNode.SUB})
>> 
>> In this test and all the following ones (including the other files), I think you can remove unrelated `failOn` regexes on operations that are not part of the test. For example, in this test you can safely remove `IRNode.MUL, DIV, and SUB`.
>
> Do you think I can remove the "LOAD" and "STORE" as well?

Yes, I think you can remove them, too, as long as there are no fields involved.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5135


More information about the hotspot-compiler-dev mailing list