RFR: 8281429: PhiNode::Value() is too conservative for tripcount of CountedLoop [v4]

Roland Westrelin roland at openjdk.java.net
Mon Apr 11 08:55:46 UTC 2022


On Tue, 29 Mar 2022 15:11:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>> 
>>  - test fix
>>  - more test
>>  - test & fix
>>  - other fix
>>  - Merge branch 'master' into JDK-8281429
>>  - exp
>>  - review
>>  - Merge branch 'master' into JDK-8281429
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - Update src/hotspot/share/opto/cfgnode.cpp
>>    
>>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>>  - ... and 3 more: https://git.openjdk.java.net/jdk/compare/d099cd7f...3a087b2c
>
> test/hotspot/jtreg/compiler/c2/irTests/TestSkeletonPredicates.java line 33:
> 
>> 31:  * @test
>> 32:  * @bug 8282592
>> 33:  * @summary C2: assert(false) failed: graph should be schedulable
> 
> Are the changes to this file intended? They seem to be unrelated.

They are unrelated but I noticed, while working on this change, that that test has the wrong bug/summary. So yes unrelated but also intended (not sure a separate change is required?)

-------------

PR: https://git.openjdk.java.net/jdk/pull/7823


More information about the hotspot-compiler-dev mailing list