RFR: 8278757: [s390] Implement AES Counter Mode Intrinsic [v8]

Lutz Schmidt lucy at openjdk.java.net
Mon Apr 25 13:39:43 UTC 2022


On Mon, 25 Apr 2022 13:00:26 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8278757: more helpful block comments and code cleanup
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 2011:
> 
>> 2009:     __ z_alcg(scratch, Address(counter, offset));          // add carry to high-order DW
>> 2010:     __ z_stg(scratch, Address(counter, offset));           // store back
>> 2011:   }
> 
> Good. Maybe add a Big Endian comment?

With Big-Endian becoming more and more exotic, I agree it might be a good idea to explain what it means. I added a three-line comment preceding the generate_increment*() emitters. Will become visible with the next commit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8142


More information about the hotspot-compiler-dev mailing list