RFR: 8278757: [s390] Implement AES Counter Mode Intrinsic [v8]

[Lutz Schmidt]

On Mon, 25 Apr 2022 13:01:56 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8278757: more helpful block comments and code cleanup
>
> src/hotspot/cpu/s390/stubGenerator_s390.cpp line 2929:
> 
>> 2927:       } else {
>> 2928:         assert(VM_Version::has_Crypto_AES_CTR(), "Inconsistent settings. Check vm_version_s390.cpp");
>> 2929:       }
> 
> A bit complicated. Why if + assert? That's redundant.

I wanted to keep at least some safety net: prevent unsupported code from being emitted (in any build mode) and issue a speaking message in non-PRODUCT builds. If you insist, I will delete the safety net and solely rely on the flag evaluation in vm_version_s390.cpp to be correct.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8142