RFR: 8291654: AArch64: assert from JDK-8287393 causes crashes

David Holmes dholmes at openjdk.org
Mon Aug 1 22:26:54 UTC 2022


On Mon, 1 Aug 2022 22:13:53 GMT, Evgeny Astigeevich <duke at openjdk.org> wrote:

> https://github.com/openjdk/jdk/commit/6cbc234ad17c5a0c4b3d6ea76f807c27c1dc8330 adds an assert checking `in_scratch_emit_size` is set during the output phase of C2 compilation. The assert can fail if C1 uses `trampoline_call`.
> The assert is not needed as the calculation of `in_scratch_emit_size` is short-circuited to false if it is C1.

Thanks for the quick fix for this one. Sorry for lack of detail but I'm out sick at the moment. I can approve this as a trivial fix as it certainly cannot do any harm to remove the assertion and fix our CI. But it would be good if the reviewers of 8287393 chimed in at some point to confirm

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9709


More information about the hotspot-compiler-dev mailing list