RFR: 8290249: Vectorize signum on AArch64 [v2]

[Andrew Haley]

On Wed, 17 Aug 2022 08:09:48 GMT, Bhavana-Kilambi <duke at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/assembler_aarch64.hpp line 3516:
>> 
>>> 3514:             FloatRegister Zn, FloatRegister Zm) {                                      \
>>> 3515:     starti;                                                                            \
>>> 3516:     assert(T != Q, "invalid size");                                                    \
>> 
>> Please wrap all of this in `#ifdef ASSERT`
>
> Thank you for reviewing. Could you please clarify by what exactly you mean by "Please wrap all of this in #ifdef ASSERT"?  Do you mean squashing the if conditions with the asserts? The assert macro calls are already inside a "#define".

That whole block is nothing but assertions. It'd be easier to read (and a little quicker to compile) if the block were surrounded by #ifdef ASSERT.

-------------

PR: https://git.openjdk.org/jdk/pull/9807