RFR: 8290249: Vectorize signum on AArch64 [v2]

Bhavana-Kilambi duke at openjdk.org
Wed Aug 17 10:10:21 UTC 2022


On Wed, 17 Aug 2022 08:22:48 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Thank you for reviewing. Could you please clarify by what exactly you mean by "Please wrap all of this in #ifdef ASSERT"?  Do you mean squashing the if conditions with the asserts? The assert macro calls are already inside a "#define".
>
> That whole block is nothing but assertions. It'd be easier to read (and a little quicker to compile) if the block were surrounded by #ifdef ASSERT.

I am sorry it's still a bit unclear to me. So we can't add the `#ifdef ASSERT` within a `#define` block. Did you mean something like this -  

#ifdef ASSERT
  #define INSN(…)
  assert()
  assert()
  ...
else
  #define INSN(…)
  // no asserts here
  ...
  ...
#undef INSN
#endif

-------------

PR: https://git.openjdk.org/jdk/pull/9807


More information about the hotspot-compiler-dev mailing list