RFR: 8251505: Use of types in compiler shared code should be consistent. [v7]
Paul Hohensee
phh at openjdk.java.net
Wed Feb 2 21:20:10 UTC 2022
On Wed, 2 Feb 2022 01:52:46 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
>> 8251505: Use of types in compiler shared code should be consistent.
>
> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert "Use jlong instead of int64_t"
Marked as reviewed by phh (Reviewer).
The traversal mark type is signed right now, so I'd leave it signed for this PR and file another one if we want to change it to unsigned. There are quite a few places where signed types are used for values that are intuitively unsigned. One reason I can think of to keep using signed types is that it's easy to detect overflow/wrap-around: just check the sign bit. Allows a bit of time to check for overflow/wrap-around without keeping an old value around.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7294
More information about the hotspot-compiler-dev
mailing list