RFR: 8251505: Use of types in compiler shared code should be consistent. [v7]

David Holmes david.holmes at oracle.com
Wed Feb 2 22:13:34 UTC 2022


On 3/02/2022 6:58 am, Paul Hohensee wrote:
> On Wed, 2 Feb 2022 01:52:46 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
> 
>>> 8251505: Use of types in compiler shared code should be consistent.
>>
>> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>>
>>    Revert "Use jlong instead of int64_t"
> 
> Hi, David, I stand corrected. Is there a document somewhere about the policy, and has anyone gone through Hotspot to remove improper use of jlong?

Hi Paul,

Sorry no documented policy, it is just something that a number of folk 
have raised in "recent" years about Java type pollution (mainly jlong) 
in various places in the VM. People have been making the switch 
piecemeal as different areas get worked on.

Cheers,
David

> So, belay my jlong suggestion, but now compileBroker.* should use int64_t. I think my gc_globals.hpp comment still stands.
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/7294


More information about the hotspot-compiler-dev mailing list