RFR: 8251505: Use of types in compiler shared code should be consistent. [v7]

David Holmes david.holmes at oracle.com
Wed Feb 2 22:14:57 UTC 2022


On 3/02/2022 7:49 am, Evgeny Astigeevich wrote:
> On Wed, 2 Feb 2022 01:52:46 GMT, Yi-Fan Tsai <duke at openjdk.java.net> wrote:
> 
>>> 8251505: Use of types in compiler shared code should be consistent.
>>
>> Yi-Fan Tsai has updated the pull request incrementally with one additional commit since the last revision:
>>
>>    Revert "Use jlong instead of int64_t"
> 
> Other missed places to change:
> 
> jvmci/jvmciEnv.hpp:  long get_long_at(JVMCIPrimitiveArray array, int index);
> services/memReporter.hpp:  inline long diff_in_current_scale(size_t s1, size_t s2) const {
> services/memReporter.hpp:    long amount = (long)(s1 - s2);
> services/memReporter.hpp:    long scale = (long)_scale;
> services/memReporter.cpp:  long amount_diff = diff_in_current_scale(current_amount, early_amount);
> services/memReporter.cpp:  long reserved_diff = diff_in_current_scale(current_reserved, early_reserved);
> services/memReporter.cpp:  long committed_diff = diff_in_current_scale(current_committed, early_committed);
> services/memReporter.cpp:      long overhead_diff = diff_in_current_scale(_current_baseline.malloc_tracking_overhead(),
> services/memReporter.cpp:  long diff_used = diff_in_current_scale(current_stats.used(),
> services/memReporter.cpp:  long diff_waste = diff_in_current_scale(current_waste, early_waste);
> runtime/vmThread.cpp:  long interval_ms = SafepointTracing::time_since_last_safepoint_ms();

Other than jvmci these are not "compiler shared code" - other cleanups 
in other areas will need their own RFE.

Cheers,
David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/7294


More information about the hotspot-compiler-dev mailing list