RFR: 8251505: Use of types in compiler shared code should be consistent.

Evgeny Astigeevich duke at openjdk.java.net
Thu Feb 3 11:34:11 UTC 2022


On Wed, 2 Feb 2022 22:16:31 GMT, David Holmes <david.holmes at oracle.com> wrote:

> > Other missed places to change:
> > jvmci/jvmciEnv.hpp:  long get_long_at(JVMCIPrimitiveArray array, int index);
> > services/memReporter.hpp:  inline long diff_in_current_scale(size_t s1, size_t s2) const {
> > services/memReporter.hpp:    long amount = (long)(s1 - s2);
> > services/memReporter.hpp:    long scale = (long)_scale;
> > services/memReporter.cpp:  long amount_diff = diff_in_current_scale(current_amount, early_amount);
> > services/memReporter.cpp:  long reserved_diff = diff_in_current_scale(current_reserved, early_reserved);
> > services/memReporter.cpp:  long committed_diff = diff_in_current_scale(current_committed, early_committed);
> > services/memReporter.cpp:      long overhead_diff = diff_in_current_scale(_current_baseline.malloc_tracking_overhead(),
> > services/memReporter.cpp:  long diff_used = diff_in_current_scale(current_stats.used(),
> > services/memReporter.cpp:  long diff_waste = diff_in_current_scale(current_waste, early_waste);
> > runtime/vmThread.cpp:  long interval_ms = SafepointTracing::time_since_last_safepoint_ms();
> 
> Other than jvmci these are not "compiler shared code" - other cleanups in other areas will need their own RFE.
> 
> Cheers, David

Created:
https://bugs.openjdk.java.net/browse/JDK-8281213
https://bugs.openjdk.java.net/browse/JDK-8281214

-------------

PR: https://git.openjdk.java.net/jdk/pull/7294


More information about the hotspot-compiler-dev mailing list