RFR: 8278947: Support for array constants in constant table [v2]
Quan Anh Mai
duke at openjdk.java.net
Tue Feb 8 22:31:14 UTC 2022
On Tue, 8 Feb 2022 18:53:40 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>>
>> - Merge branch 'master' into constantVectorUpdate
>> - update copyright
>> - missing type in array_constant
>> - Merge branch 'master' into constantVector
>> - use constant table for remaining types
>> - Merge branch 'master' into constantVector
>> - refactor
>> - replicate using constant
>> - Merge branch 'master' into constantVector
>> - initial commit
>
> src/hotspot/share/opto/constantTable.hpp line 41:
>
>> 39: private:
>> 40: BasicType _type;
>> 41: bool _is_array;
>
> Can you rely on `_type` and just use `T_ARRAY` tag for that purpose?
In that case, an additional field would be needed to identify the type of the elements anyway.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6908
More information about the hotspot-compiler-dev
mailing list