[jdk18] RFR: 8278267: ARM32: several vector test failures for ASHR [v3]
Dean Long
dlong at openjdk.java.net
Mon Jan 10 09:55:40 UTC 2022
On Mon, 10 Jan 2022 02:13:00 GMT, Hao Sun <haosun at openjdk.org> wrote:
>> You can put the assert into a helper function. You can look in aarch64.ad for examples.
>>
>> bool assert_not_var_shift(const Node *n) {
>> assert(!n->as_ShiftV()->is_var_shift(), "illegal var shift");
>> return true;
>> }
>>
>> [...]
>>
>> predicate(n->as_Vector()->length() == 8 && assert_not_var_shift(n));
>
> @dean-long I believe your comments are addressed in the latest commit. Could you please help to take a review when you got a chance? Thanks.
Yes, your changes look good. Approved.
-------------
PR: https://git.openjdk.java.net/jdk18/pull/41
More information about the hotspot-compiler-dev
mailing list