RFR: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors [v2]

Dean Long dlong at openjdk.org
Tue Jul 5 23:40:49 UTC 2022


On Tue, 5 Jul 2022 16:36:03 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/arm/c1_LIRAssembler_arm.cpp line 2438:
>> 
>>> 2436:       int null_check_offset = __ offset();
>>> 2437:       __ null_check(obj);
>>> 2438:       add_debug_info_for_null_check(null_check_offset, op->info());
>> 
>> Is this equivalent to the following?
>> 
>> add_debug_info_for_null_check_here(op->info());
>> __ null_check(obj);
>
> I don't know.  Is it better and preferable?  It looks better.

I like it better.  Thanks for changing it.

-------------

PR: https://git.openjdk.org/jdk/pull/9339


More information about the hotspot-compiler-dev mailing list