RFR: 8278479: RunThese test failure with +UseHeavyMonitors and +VerifyHeavyMonitors [v2]

[Dean Long]

On Tue, 5 Jul 2022 16:34:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp line 2563:
>> 
>>> 2561:     if (op->info() != NULL) {
>>> 2562:       int null_check_offset = __ offset();
>>> 2563:       __ null_check(obj, -1);
>> 
>> Suggestion:
>> 
>>       __ null_check(obj);
>
> Yes, that would be better but it leads to a compilation error on macosx-aarch64 that null_check is ambiguous:
> 
> src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp:2563:10: error: call to member function 'null_check' is ambiguous
> [2022-06-30T00:09:19,094Z]       __ null_check(obj);
> [2022-06-30T00:09:19,094Z]       ~~~^~~~~~~~~~
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp:602:16: note: candidate function
> [2022-06-30T00:09:19,094Z]   virtual void null_check(Register reg, int offset = -1);
> [2022-06-30T00:09:19,094Z]                ^
> src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.hpp:109:8: note: candidate function
> [2022-06-30T00:09:19,094Z]   void null_check(Register r, Label *Lnull = NULL) { MacroAssembler::null_check(r); }
> [2022-06-30T00:09:19,094Z]        ^

OK, nevermind.

-------------

PR: https://git.openjdk.org/jdk/pull/9339