RFR: 8289186: Support predicated vector load/store operations over X86 AVX2 targets. [v2]
Xiaohong Gong
xgong at openjdk.org
Wed Jul 6 07:52:31 UTC 2022
On Tue, 5 Jul 2022 18:31:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8289186: Review comments resolved.
>
> src/hotspot/share/opto/vectornode.hpp line 907:
>
>> 905: StoreVectorMaskedNode(Node* c, Node* mem, Node* dst, Node* src, const TypePtr* at, Node* mask)
>> 906: : StoreVectorNode(c, mem, dst, at, src) {
>> 907: assert(mask->bottom_type()->isa_vectmask(), "sanity");
>
> Why the assert was added before? And why you can remove it now?
Does this mean the `mask` input can be a normal `vect_type ` like the mask input of `VectorBlend` for `LoadVectorMasked/StoreVectorMasked` over X86 AVX2 systems? They do not depend on the predicated feature for the AVX2 systems, right?
-------------
PR: https://git.openjdk.org/jdk/pull/9324
More information about the hotspot-compiler-dev
mailing list