RFR: 8289186: Support predicated vector load/store operations over X86 AVX2 targets. [v3]
Jatin Bhateja
jbhateja at openjdk.org
Wed Jul 6 13:18:02 UTC 2022
On Wed, 6 Jul 2022 07:48:50 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> src/hotspot/share/opto/vectornode.hpp line 907:
>>
>>> 905: StoreVectorMaskedNode(Node* c, Node* mem, Node* dst, Node* src, const TypePtr* at, Node* mask)
>>> 906: : StoreVectorNode(c, mem, dst, at, src) {
>>> 907: assert(mask->bottom_type()->isa_vectmask(), "sanity");
>>
>> Why the assert was added before? And why you can remove it now?
>
> Does this mean the `mask` input can be a normal `vect_type ` like the mask input of `VectorBlend` for `LoadVectorMasked/StoreVectorMasked` over X86 AVX2 systems? They do not depend on the predicated feature for the AVX2 systems, right?
IR was specifically added for predicated targets (AVX512 and ARM's SVE), this patch is re-using this IR for non-predicated AVX2 target where mask could be a vector type.
-------------
PR: https://git.openjdk.org/jdk/pull/9324
More information about the hotspot-compiler-dev
mailing list