RFR: 8288897: Clean up node dump code [v4]

[Emanuel Peter]

On Wed, 13 Jul 2022 22:07:50 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implementing Christians review suggestions
>
> src/hotspot/share/opto/node.cpp line 2671:
> 
>> 2669: //   only_data:     whether to regard data edges only during traversal.
>> 2670: static void collect_nodes_i(GrowableArray<Node*>* queue, const Node* start, int direction, uint depth, bool include_start, bool only_ctrl, bool only_data) {
>> 2671:   bool indent = depth <= PrintIdealIndentThreshold;
> 
> hi, @eme64 , 
> Could you also delete PrintIdealIndentThreshold from c2_globals.hpp?
> This is like a hack to let node::dump() indent. I don't think it's quite useful.  it can be done in gdb pretty-print

Oh thank you so much, I overlooked this! Will delete it.

-------------

PR: https://git.openjdk.org/jdk/pull/9234