RFR: 8288897: Clean up node dump code [v4]

Emanuel Peter epeter at openjdk.org
Thu Jul 14 09:05:03 UTC 2022


On Thu, 14 Jul 2022 06:54:52 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   implementing Christians review suggestions
>
> src/hotspot/share/opto/node.cpp line 2079:
> 
>> 2077:   tty->print("      @: print old nodes - before matching (if available)\n");
>> 2078:   tty->print("      B: print scheduling blocks (if available)\n");
>> 2079:   tty->print("      $: dump only, no header, no other columns\n");
> 
> why don't we just list those options in alphabetical order? 
> It's a little bit easier to interpret the default value 'cdmxo at B'  if we  flip order 'print m:... ' and 'print d:...' above.

Thanks, will reorder, good idea

-------------

PR: https://git.openjdk.org/jdk/pull/9234


More information about the hotspot-compiler-dev mailing list